Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pmapper.StakingOptions #236

Closed
wants to merge 1 commit into from
Closed

Remove pmapper.StakingOptions #236

wants to merge 1 commit into from

Conversation

dhrubabasu
Copy link
Contributor

This was a copy of pmapper.StakingMetadata. We can unmarshal into it directly

@dhrubabasu dhrubabasu self-assigned this Feb 9, 2024
@patrick-ogrady patrick-ogrady self-requested a review February 9, 2024 22:58
patrick-ogrady
patrick-ogrady suggested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past, we've kept options/metadata different because they are used in different endpoints.

Not sure if we should unify.

@dhrubabasu dhrubabasu closed this Feb 9, 2024
@dhrubabasu dhrubabasu deleted the remove-extra-struct branch February 9, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-ogrady patrick-ogrady patrick-ogrady requested changes

Assignees

@dhrubabasu dhrubabasu

Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhrubabasu @patrick-ogrady