Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rpc options when bootstrapping network #567

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

cam-schultz
Copy link
Collaborator

Why this should be merged

Fixes a bug introduced in #559 that does not use the configured RPC parameters when calling the P-Chain API on network startup. This causes deployments that utilize API tokens or query parameters to fail to start.

How this works

Fetches the configured RPC settings before calling the C-Chain client.

How this was tested

How is this documented

Copy link
Contributor

@iansuvak iansuvak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I prefer #568 but we can get this out in the meantime

@cam-schultz cam-schultz merged commit f12ae46 into main Nov 26, 2024
8 checks passed
@cam-schultz cam-schultz deleted the fix-pclient-dial branch November 26, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants