CP-9319: K2-Avatars #2138
CP-9319: K2-Avatars #2138
Conversation
| @@ -138,7 +138,7 @@ | |||
| "react-native-dialog": "8.2.0", | |||
| "react-native-fast-image": "8.6.3", | |||
| "react-native-fs": "2.20.0", | |||
| "react-native-gesture-handler": "2.20.0", | |||
| "react-native-gesture-handler": "2.14.1", | |||
There was a problem hiding this comment.
had to downgrade due to compatibility issue with expo
| "react-native-reanimated": "3.6.2", | ||
| "react-native-reanimated-carousel": "v4.0.0-canary.22", |
There was a problem hiding this comment.
introduced for implementing infinite scrolling. I had to modify it slightly to allow touch events outside the item layout for implementing our hexagonal multi-row layout. I opened a pr and they merged it quickly.
| const pressedAnimatedStyle = useAnimatedStyle(() => ({ | ||
| transform: [{ scale: pressedAnimation.value }] | ||
| })) | ||
| const surfacePrimaryBlurBg = theme.isDark ? '#050506' : undefined // to cancel out the blur effect on the $surfacePrimary, we need to use a darker background color for the blur view, only for dark mode |
There was a problem hiding this comment.
I had to set a slightly darker background(#050506) beneath the blur view to eliminate the color difference between the blurred $surfacePrimary and the $surfacePrimary. This issue occurs only in dark mode. This screenshot illustrates the result when the darker background is not set(though the difference is very subtle).
There was a problem hiding this comment.
nice work around. can you let design know about this in case they want to change something?
There was a problem hiding this comment.
synced with design team.
onghwan
requested review from
neven-s,
atn4z7 and
ruijialin-avalabs
as code owners
Description
Ticket: CP-9319
Screenshots/Videos
iOS
Screen.Recording.2024-11-29.at.2.30.34.PM.mov
Android
Screen.Recording.2024-11-29.at.2.32.19.PM.mov