Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-9603: Toasts #2140

Merged
merged 8 commits into from
Dec 9, 2024
Merged

CP-9603: Toasts #2140

merged 8 commits into from
Dec 9, 2024

Conversation

onghwan
Copy link
Contributor

@onghwan onghwan commented Dec 4, 2024

Description

Ticket: CP-9603

  • implements the components for snackbar, notification alerts(figma) and their storybook in k2-alpine
  • implement GlobalToast and showToast/hideToast util functions in mobile.

Screenshots/Videos

light dark
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-04.at.10.26.08.mp4

const hasMessage = !!message

return (
<TouchableWithoutFeedback style={style} testID={testID} onPress={onPress}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this just be Pressable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

Copy link
Contributor

@ruijialin-avalabs ruijialin-avalabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onghwan onghwan merged commit b85ed7c into main Dec 9, 2024
5 checks passed
@onghwan onghwan deleted the CP-9603 branch December 9, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants