Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playwright and core.app integration #2141

Merged
merged 8 commits into from
Dec 4, 2024
Merged

playwright and core.app integration #2141

merged 8 commits into from
Dec 4, 2024

Conversation

eunjisong
Copy link
Contributor

@eunjisong eunjisong commented Dec 4, 2024

Description

  • This is NOT the final integration but it's possible to run the dapp connection testing for core.app <> mobile on the local machine with ios debug build.
  • Playwright test:core.spec.ts
  • Detox test: core.e2e.playwright.ts
  • node script: core/run-tests.js

How to test this:

  1. run node core/run-tests.js

What is happening?
When running the run-tests.js file, we run core.spec.ts first and then the detox test, core.e2e.playwright.ts kicks off after the playwright test passes. Currently, it's not set up on ci/cd yet, and we can only run it locally with ios debug build.

Next

  • I'll utilize run-tests.js to run the full playwright package.
  • I'll add other dapps connection coverage
  • I'll add other dapps swap coverage
  • Core.app feature testing (chain transfer, staking, signing...)
  • Playground RPC call testing

Testing

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

eunjisong and others added 5 commits December 4, 2024 11:33
Signed-off-by: Eunji Song <32075932+eunjisong@users.noreply.github.com>
Comment on lines 242 to 244
"playwright-extra": "^4.3.6",
"postinstall-postinstall": "2.1.0",
"puppeteer-extra-plugin-stealth": "^2.11.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use absolute versions

@eunjisong eunjisong marked this pull request as ready for review December 4, 2024 19:58
@eunjisong eunjisong merged commit a68977a into main Dec 4, 2024
4 checks passed
@eunjisong eunjisong deleted the qa/new_playwright branch December 4, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants