Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA fix staking and rpc call testing #2142

Merged
merged 1 commit into from
Dec 5, 2024
Merged

QA fix staking and rpc call testing #2142

merged 1 commit into from
Dec 5, 2024

Conversation

eunjisong
Copy link
Contributor

@eunjisong eunjisong commented Dec 5, 2024 •
edited
Loading

Description

  • We tested all the possible duration stake testing, but it failed due to the existing bug and always became flaky. On this PR, I randomly chose one duration, and we'll only test one stake on testnet. It could fail again if it chooses a different fee other than normal, but it will be addressed soon.
  • This PR also contains other small flakiness around the testing suite

Screenshots/Videos

Testing

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@eunjisong eunjisong marked this pull request as ready for review December 5, 2024 17:00
Any2suited66
Any2suited66 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@Any2suited66 Any2suited66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Makes the tests much more resilient

@eunjisong eunjisong merged commit 0a044e4 into main Dec 5, 2024
4 checks passed
@eunjisong eunjisong deleted the qa/fix-125 branch December 5, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Any2suited66 Any2suited66 Any2suited66 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjisong @Any2suited66