Fix double notification on Android #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neven-s
requested review from
atn4z7,
ruijialin-avalabs and
onghwan
as code owners
onghwan
reviewed
Dec 18, 2024
| @@ -321,16 +321,14 @@ class NotificationsService { | |||
| pressAction: { | |||
| id: PressActionId.OPEN_PORTFOLIO, | |||
| launchActivity: LAUNCH_ACTIVITY | |||
| } | |||
| }, | |||
| channelId: channelId ?? '' | |||
There was a problem hiding this comment.
Is there a difference between passing an empty string and undefined for channelId?
There was a problem hiding this comment.
yes, in my experience notifee will report such payload as invalid
There was a problem hiding this comment.
it's weird since channelId is an optional parameter.
There was a problem hiding this comment.
it's optional for ios platform, on android it's required
onghwan
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9567
This fixes double notification on Android devices when app is in background since FirebaseSDK automatically handles FCM with
notificationpayload.Testing
Checklist
Please check all that apply (if applicable)