Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-9517: Use tokenInCurrencyFormatter to show rewards and fees for staking #2159

Merged
merged 3 commits into from
Dec 16, 2024
Merged

CP-9517: Use tokenInCurrencyFormatter to show rewards and fees for staking #2159

merged 3 commits into from
Dec 16, 2024

Conversation

onghwan
Copy link
Contributor

@onghwan onghwan commented Dec 16, 2024 •
edited by jira bot
Loading

Description

Ticket: CP-9517

  • Use the tokenInCurrencyFormatter function to correctly display the claimable amount and fee.
  • Fixed a bug where the currency symbol was duplicated when using currencies other than USD.

Screenshots/Videos

Before After
Stakes(USD)
Stakes(CLP)
Claim Rewards(USD)

@onghwan onghwan changed the title CP-9517: Use formatter to show claimable amount and fees CP-9517: Use tokenInCurrencyFormatter to show rewards and fees for staking Dec 16, 2024
neven-s
neven-s approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@neven-s neven-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@onghwan onghwan merged commit 58f883d into main Dec 16, 2024
4 checks passed
@onghwan onghwan deleted the CP-9517 branch December 16, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neven-s neven-s neven-s approved these changes

@atn4z7 atn4z7 Awaiting requested review from atn4z7 atn4z7 is a code owner

@ruijialin-avalabs ruijialin-avalabs Awaiting requested review from ruijialin-avalabs ruijialin-avalabs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onghwan @neven-s