CP-9375 Don't show Use Wallet Connect dialog if not interacted with app #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neven-s
requested review from
atn4z7,
ruijialin-avalabs and
onghwan
as code owners
neven-s
changed the title
atn4z7
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9375
This is best effort to not show
Use Wallet Connectdialog which pops up randomly in some cases.The fix is that we track if user have interacted with dApp and only then allow detection of underlying ethereum callbacks upon which we conclude that dApp tried to connect with non-core wallet.
However, there still can be cases when dialog pops up since this is not documented feature.
Screenshots/Videos
Screen.Recording.2024-12-20.at.17.07.33.mov
Testing
Checklist
Please check all that apply (if applicable)