Make merkle::get_iter crate-only public

Also removed incorrect comment and comment about DiskAddress::is_null
ava-labs · Nov 15, 2023 · 133f949 · 133f949
1 parent 55bc47a
commit 133f949
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/firewood/src/db.rs b/firewood/src/db.rs
@@ -320,7 +320,6 @@ impl<S: ShaleStore<Node> + Send + Sync> DbRev<S> {
         &self,
         start_key: Option<K>,
     ) -> Result<merkle::MerkleKeyValueStream<'_, S>, api::Error> {
-        // TODO: get first key when start_key is None
         self.merkle
             .get_iter(start_key, self.header.kv_root)
             .map_err(|e| api::Error::InternalError(e.into()))

diff --git a/firewood/src/merkle.rs b/firewood/src/merkle.rs
@@ -1179,12 +1179,11 @@ impl<S: ShaleStore<Node> + Send + Sync> Merkle<S> {
         self.store.flush_dirty()
     }
 
-    pub fn get_iter<K: AsRef<[u8]>>(
+    pub(crate) fn get_iter<K: AsRef<[u8]>>(
         &self,
         key: Option<K>,
         root: DiskAddress,
     ) -> Result<MerkleKeyValueStream<'_, S>, MerkleError> {
-        // TODO: if DiskAddress::is_null() ...
         Ok(MerkleKeyValueStream {
             key_state: IteratorState::new(key),
             merkle_root: root,