Cleanup: Avoid using explicit into #199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I prefer Ok(whatever()?) to whatever().map_err(Into::into)
| @@ -900,8 +903,7 @@ impl Db { | |||
| &self.cfg.rev, | |||
| ) | |||
| .unwrap(), | |||
| } | |||
| .into() | |||
| }) | |||
There was a problem hiding this comment.
This is less flexible than the previous code. Now if you change the function signature, you have to change the function body. Whereas before, as long as From<Revision> is implemented for the new return type, the function body doesn't need to change.
I also just think the old code looks better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I prefer Ok(whatever()?) to whatever().map_err(Into::into)