Nibbles improvements #208
Merged
Nibbles improvements #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than implement skip() at the Nibbles layer, you get `Iter::skip` efficiently if you implement `Iter::nth`. This is trivial to do for Nibbles, and solves the problem of `skip(0)` on `Nibbles::<1>`, which now works correctly (test included) Implementing `Iter::size_hint()` allows for a size check as well, which makes `Nibbles::len()` less useful, but I'm keeping it so that `size_hint` can use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than implement skip() at the Nibbles layer, you get
Iter::skipefficiently if you implementIter::nth. This is trivial to do for Nibbles, and solves the problem ofskip(0)onNibbles::<1>, which now works correctly (test included)Implementing
Iter::size_hint()allows for a size check as well, which makesNibbles::len()less useful, but I'm keeping it so thatsize_hintcan use it.