cleanups #212
Merged
cleanups #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
commented
Aug 23, 2023
There was a problem hiding this comment.
Could be broken up further, but at least it's under 1k lines. Not sure how scary it is that there are no specific tests for this one...
richardpringle
force-pushed
the
cleanups
branch
from
b070a94
to
e87d893
Compare
hexfusion
reviewed
Aug 23, 2023
| @@ -1,5 +1,5 @@ | |||
| [package] | |||
| name = "firewood-growth-ring" | |||
| name = "growth-ring" | |||
There was a problem hiding this comment.
The reason these have a prefix is that we don't own these namespaces in crates.io.
There was a problem hiding this comment.
I think we can deal with that when it comes time to publish.
rkuris
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken up into the following commits:
firewood-prefix from sub-cratesIf there are any conflicts with stuff you're working on, @rkuris, let me know and I can create separate PRs.
Scope:
I only moved code, if you spot anything odd, I'm happy to clean it up in a follow up PR.