Remove ValueTransformer + IdTrans #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
approved these changes
Aug 24, 2023
| @@ -369,7 +369,7 @@ impl<F: WalFile + 'static, S: WalStore<F>> WalFilePool<F, S> { | |||
| let mut last_h: Option< | |||
| Pin<Box<dyn Future<Output = Result<WalFileHandle<'a, F, S>, WalError>> + 'a>>, | |||
| > = None; | |||
| for ((next_fid, wl), h) in meta.into_iter().zip(files.into_iter()) { | |||
| for ((next_fid, wl), h) in meta.into_iter().zip(files) { | |||
There was a problem hiding this comment.
Haha... now I'm going to give some feedback that I should also probably listen to myself... please don't combine changes like these in an unrelated PR (in the future).
AND... please request the same of me when I undoubtedly do the same thing.
There was a problem hiding this comment.
Oh... just read a message offline. It's weird that the linter is suddenly failing.
AND... please request the same of me when I undoubtedly do the same thing.
^^ this still stands though
There's only ever one
Seems to be a new check
rkuris
force-pushed
the
rkuris/transformers-robots-in-disguise
branch
from
d23571b
to
bd24574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's only ever one