Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verify option to insert example #321

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Add verify option to insert example #321

merged 2 commits into from
Oct 17, 2023

Conversation

rkuris
Copy link
Collaborator

@rkuris rkuris commented Oct 16, 2023

This example now allows you to read-verify some of the inserted values. It does make a copy of the inserted values since propose consumes the batch.

@rkuris
Add verify option to insert example
a249864 
This example now allows you to read-verify some of the inserted values.
It does make a copy of the inserted values since propose consumes the
batch.
richardpringle
richardpringle reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@richardpringle richardpringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes make the example harder to read, to be honest.

@rkuris
Copy link
Collaborator Author

rkuris commented Oct 16, 2023

I think these changes make the example harder to read, to be honest.

Is this better?

@richardpringle richardpringle merged commit d31113c into main Oct 17, 2023
5 checks passed
@richardpringle richardpringle deleted the rkuris/add-verify-to-insert-example branch October 17, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpringle richardpringle richardpringle approved these changes

@xinifinity xinifinity Awaiting requested review from xinifinity

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkuris @richardpringle