More merkle.rs cleanup #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
commented
Oct 24, 2023
richardpringle
force-pushed
the
more-cleanup
branch
from
16134b8 to
c7d12f4
Compare
rkuris
requested changes
Oct 25, 2023
richardpringle
force-pushed
the
more-cleanup
branch
3 times, most recently
from
9a451e1 to
a9aa6b3
Compare
rkuris
approved these changes
Oct 26, 2023
richardpringle
force-pushed
the
more-cleanup
branch
from
a9aa6b3 to
42ed868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still a little more work to do, but the testing logic isn't trival so I left a TODO