Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check all features #330

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Check all features #330

merged 1 commit into from
Oct 25, 2023

Conversation

richardpringle
Copy link
Contributor

Make sure clippy checks all-features

rkuris
rkuris approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@rkuris rkuris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I love this, since now we could theoretically have a failure that depends on some feature being turned off. Of course, I suppose in that case we'd catch it during our regular development, so I guess this is okay.

@richardpringle richardpringle merged commit 24657c4 into main Oct 25, 2023
5 checks passed
@richardpringle richardpringle deleted the all-features branch October 25, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkuris rkuris rkuris approved these changes

@xinifinity xinifinity Awaiting requested review from xinifinity

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardpringle @rkuris