Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MSIZE from DiskAddress #335

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Remove MSIZE from DiskAddress #335

merged 6 commits into from
Oct 31, 2023

Conversation

rkuris
Copy link
Collaborator

@rkuris rkuris commented Oct 30, 2023

Now actually uses the size of the struture for computing how many bytes to write.

@rkuris
Remove MSIZE from DiskAddress
6221e0d 
Now actually uses the size of the struture for computing how many bytes
to write.
richardpringle
richardpringle requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@richardpringle richardpringle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it would be insane for someone to mess this up, but if you use the same constant, it's a little more clear that the function-return, view-size, and error all contain the exact same thing

shale/src/disk_address.rs Show resolved Hide resolved
@rkuris rkuris requested a review from richardpringle October 31, 2023 02:20
@richardpringle richardpringle merged commit 19edacf into main Oct 31, 2023
5 checks passed
@richardpringle richardpringle deleted the rkuris/shale-cleanup-project-3 branch October 31, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinifinity xinifinity xinifinity approved these changes

@richardpringle richardpringle richardpringle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkuris @richardpringle @xinifinity