More shale cleanups #337
Merged
More shale cleanups #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
approved these changes
Nov 1, 2023
| @@ -253,7 +253,7 @@ impl<M: CachedStore> CompactSpaceInner<M> { | |||
| .unwrap(); | |||
|
|
|||
| if desc_addr != DiskAddress(**self.header.meta_space_tail) { | |||
| let desc_last = self.get_descriptor(**self.header.meta_space_tail.value)?; | |||
| let desc_last = self.get_descriptor(*self.header.meta_space_tail.value)?; | |||
There was a problem hiding this comment.
so much less pizzazz though...
| @@ -99,7 +99,7 @@ pub trait CachedStore: Debug + Send + Sync { | |||
| /// . Users of [ShaleStore] implementation, however, will only use [ObjRef] for safeguarded access. | |||
| #[derive(Debug)] | |||
| pub struct Obj<T: Storable> { | |||
| value: Box<StoredView<T>>, | |||
| value: StoredView<T>, | |||
There was a problem hiding this comment.
One less indirection, 🎉
| @@ -109,7 +109,7 @@ impl<T: Storable> Obj<T> { | |||
| DiskAddress(NonZeroUsize::new(self.value.get_offset())) | |||
| } | |||
|
|
|||
| /// Write to the underlying object. Returns `Some(())` on success. | |||
| /// Write to the underlying object. Returns `Ok(())` on success. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small doc fix and remove Box around StoredView