DiskAddress is already a more efficient Option<> #341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes Option<DiskAddress> from BranchNodes
Dump was failing because it was attempting to read a zero address
richardpringle
requested changes
Nov 3, 2023
xinifinity
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM, although, talked to @richardpringle offline, it seems this conflicts with his major refactor/work on Merkle with #344. Not sure how easy or does it make sense to rebase on top?
richardpringle
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Upon further review, I don't think that we should do this. It doesn't make sense to have an uninitialized DiskAddress. The only valid place that I see this happening is related to Extension nodes and currently, calling serialize on a DiskAddress that has not been initialized will panic.
Instead, DiskAddress should simply wrap NonZeroUsize, and parent types can use Option<DiskAddress>.
|
Lets change DiskAddress to not be an Option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Option from BranchNodes