-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rkuris/streaming iterator from start #346
Commits on Nov 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 969684f - Browse repository at this point
Copy the full SHA 969684fView commit details
Commits on Nov 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c806b7a - Browse repository at this point
Copy the full SHA c806b7aView commit details
Commits on Nov 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9bb6cd3 - Browse repository at this point
Copy the full SHA 9bb6cd3View commit details
Commits on Nov 8, 2023
-
There are several TODOs here, but the code works for the two test cases I created. Both of these avoid making extension nodes, which are going away, and this code may need some tweaks to support values inside branch nodes.
Configuration menu - View commit details
-
Copy full SHA for 46aecef - Browse repository at this point
Copy the full SHA 46aecefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 116d83b - Browse repository at this point
Copy the full SHA 116d83bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c31eb9 - Browse repository at this point
Copy the full SHA 0c31eb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5e69c6 - Browse repository at this point
Copy the full SHA f5e69c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6e36d0 - Browse repository at this point
Copy the full SHA e6e36d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e25d42b - Browse repository at this point
Copy the full SHA e25d42bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8273434 - Browse repository at this point
Copy the full SHA 8273434View commit details
Commits on Nov 9, 2023
-
Redo the loop to have an IteratorState
IteratorState is any of: - Start at the beginning of the trie - Start at a specific key value of the trie - Continue after a saved node and parents See the inline comments for more details. TODO: - Implement StartAtBegininng (and tests) - If a key is provided that doesn't exist, start iterating at the next one (if we really need this) - If an error is returned, we should next return None, then start from the beginning. This makes the resumption after an error a little cleaner. We'd need another IteratorState for this. - Remove extension nodes (depends on other diffs)
Configuration menu - View commit details
-
Copy full SHA for 36ce8cc - Browse repository at this point
Copy the full SHA 36ce8ccView commit details -
Removed unnecessary reference in remove()
This was an artifact from an earlier change. Reverted back to original.
Configuration menu - View commit details
-
Copy full SHA for 4d5f65c - Browse repository at this point
Copy the full SHA 4d5f65cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 692018a - Browse repository at this point
Copy the full SHA 692018aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17f4713 - Browse repository at this point
Copy the full SHA 17f4713View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ab9003 - Browse repository at this point
Copy the full SHA 7ab9003View commit details -
Removed unnecessary clone Added additional comments Added TODO for a few things: - possible to return a reference to the value instead of a copy - should handle case of branch nodes with values while traversing Adding a randomized key-value test after extension nodes are removed is also recommended.
Configuration menu - View commit details
-
Copy full SHA for 4867f82 - Browse repository at this point
Copy the full SHA 4867f82View commit details
Commits on Nov 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for afe6357 - Browse repository at this point
Copy the full SHA afe6357View commit details
Commits on Nov 11, 2023
-
This walks down the leftmost branch every time, recording the path down, then figuring out what the key and value is at the bottom, then resumes. Also refactors get_key_from_parents, as this is now done 3 times in the code, sometimes when we add a leaf key value, and other times when not.
Configuration menu - View commit details
-
Copy full SHA for 8b3648f - Browse repository at this point
Copy the full SHA 8b3648fView commit details
Commits on Nov 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9803ae3 - Browse repository at this point
Copy the full SHA 9803ae3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2af1991 - Browse repository at this point
Copy the full SHA 2af1991View commit details -
Add doc comments to MerkleKeyValueStream
Moved the comments about the behavior at the end of the stream to doc comments on the iterator. Per review comments.
Configuration menu - View commit details
-
Copy full SHA for 936d0b5 - Browse repository at this point
Copy the full SHA 936d0b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94a4244 - Browse repository at this point
Copy the full SHA 94a4244View commit details -
Found_offset is now a separate statement
Not 100% sure this is what the reviewer asked for, but this is okay too.
Configuration menu - View commit details
-
Copy full SHA for dcfb338 - Browse repository at this point
Copy the full SHA dcfb338View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e8193b - Browse repository at this point
Copy the full SHA 1e8193bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98f1b28 - Browse repository at this point
Copy the full SHA 98f1b28View commit details -
Configuration menu - View commit details
-
Copy full SHA for a862043 - Browse repository at this point
Copy the full SHA a862043View commit details -
Configuration menu - View commit details
-
Copy full SHA for b952bc6 - Browse repository at this point
Copy the full SHA b952bc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b18d91f - Browse repository at this point
Copy the full SHA b18d91fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 895507d - Browse repository at this point
Copy the full SHA 895507dView commit details -
Added cases of starting in the middle and at the last key
Configuration menu - View commit details
-
Copy full SHA for 33553e6 - Browse repository at this point
Copy the full SHA 33553e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dfd789 - Browse repository at this point
Copy the full SHA 8dfd789View commit details -
Configuration menu - View commit details
-
Copy full SHA for b64e98e - Browse repository at this point
Copy the full SHA b64e98eView commit details -
Apply suggestions from code review
The loop to calculate the next found position and address can be a little simpler using enumerate, skip, and filter_map.
Configuration menu - View commit details
-
Copy full SHA for 55bc47a - Browse repository at this point
Copy the full SHA 55bc47aView commit details
Commits on Nov 15, 2023
-
Make merkle::get_iter crate-only public
Also removed incorrect comment and comment about DiskAddress::is_null
Configuration menu - View commit details
-
Copy full SHA for 133f949 - Browse repository at this point
Copy the full SHA 133f949View commit details