Enable lints for discussion #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These lints are only in fwdctl because it was easy to fix the few errors that popped up. Once we agree these are the right lints, we can move them to the top level. For ease of review, here are links to the lint descriptions we are enabling as well reasons why I think they are important: - https://rust-lang.github.io/rust-clippy/rust-1.74.0/index.html#/unwrap_used - - code that panics should be avoided, except in tests - - not all panics have good error messages - https://rust-lang.github.io/rust-clippy/rust-1.74.0/index.html#/indexing_slicing - - panics - - there are good alternatives to index dereference that do not panic - https://rust-lang.github.io/rust-clippy/rust-1.74.0/index.html#/explicit_deref_methods - - easier and clearer just to dereference - https://rust-lang.github.io/rust-clippy/rust-1.74.0/index.html#/missing_const_for_fn - - non-const functions prevent callers from being const
richardpringle
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lints are only in fwdctl because it was easy to fix the few errors that popped up. Once we agree these are the right lints, we can move them to the top level.
For ease of review, here are links to the lint descriptions we are enabling as well reasons why I think they are important: