Rkuris/manual serialization #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the packing, fix a few bugs, and rerun the benchmarks. On my mac, leaves go from 41ns to 33ns Small branches go from 73ns to 41ns Full branches go from 211ns to 48ns. This should have a significant effect as we will be serializing about 6B nodes, most of them branches, when inserting 1B rows. Also included: - README lint fixes - Additional help for benchmark cmd line
This should reduce the number of system calls
Test can fail due to reuse of a temp file from a previous run or if the tests run in a different order.
…ewood into rkuris/manual-serialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.