Feat/new p chain methods #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
reviewed
Nov 26, 2024
app/rust/src/parser/l1_validator.rs
Outdated
| @@ -0,0 +1,67 @@ | |||
| /******************************************************************************* | |||
| * (c) 2021 Zondax GmbH | |||
There was a problem hiding this comment.
Could take the opportunity to update this, right?
emmanuelm41
reviewed
Nov 26, 2024
app/rust/src/parser/transactions.rs
Outdated
Comment on lines
425
to
429
| Self::ConvertSubnetToL1(tx) => tx.num_items(), | ||
| Self::IncreaseL1ValidatorBalance(tx) => tx.num_items(), | ||
| Self::DisableL1Validator(tx) => tx.num_items(), | ||
| Self::SetL1ValidatorWeight(tx) => tx.num_items(), | ||
| Self::RegisterL1Validator(tx) => tx.num_items(), |
There was a problem hiding this comment.
Should feature banff be added here too?
emmanuelm41
reviewed
Nov 26, 2024
tests_zemu/snapshots/fl-sign-convert_subnet_to_l1_validator/00002.png
Outdated
Show resolved
Hide resolved
emmanuelm41
reviewed
Nov 26, 2024
There was a problem hiding this comment.
Too long title here... it goes out of screen
There was a problem hiding this comment.
I will take a look on the snapshots
emmanuelm41
requested changes
Nov 26, 2024
emmanuelm41
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.