Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/eth msg #341

Merged
merged 15 commits into from
Dec 10, 2024
Merged

Fix/eth msg #341

merged 15 commits into from
Dec 10, 2024

Conversation

neithanmo
Copy link
Collaborator

Changes in this PR:

  • Enhancements in message handling: Introduced chunked processing for large ASCII and non-ASCII messages with proper formatting, improving device display capabilities for both Ethereum and Avalanche personal messages.
  • Improved code readability and maintainability: Simplified logic in DisplayableItem implementations and enhanced test coverage for message chunking edge cases.
  • Reduced logging noise: Removed redundant zemu_log calls in APDU handlers.
  • Dependency updates: Updated submodules and scripts for improved functionality and alignment with TypeScript in tests_zemu.
  • Minor fixes: Corrected constants, such as MSG_MAX_CHUNK_LEN, and ensured progressive review for signing transactions.

@emmanuelm41 emmanuelm41 merged commit 10a442c into main Dec 10, 2024
65 checks passed
@emmanuelm41 emmanuelm41 deleted the fix/eth_msg branch December 10, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants