-
Notifications
You must be signed in to change notification settings - Fork 232
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add p2p handler for acp-118 sig request (#1260)
* add p2p handler for acp-118 sig request * update to use addressed payload and hash types from avago * add future TODOs * nit: log unexpected type in error * nit
- Loading branch information
Showing
7 changed files
with
406 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,160 @@ | ||
| // (c) 2024, Ava Labs, Inc. All rights reserved. | ||
| // See the file LICENSE for licensing terms. | ||
|
|
||
| package handlers | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "time" | ||
|
|
||
| "github.com/ava-labs/avalanchego/codec" | ||
| "github.com/ava-labs/avalanchego/ids" | ||
| "github.com/ava-labs/avalanchego/network/p2p" | ||
| "github.com/ava-labs/avalanchego/proto/pb/sdk" | ||
| "github.com/ava-labs/avalanchego/snow/engine/common" | ||
| "github.com/ava-labs/avalanchego/utils/crypto/bls" | ||
| avalancheWarp "github.com/ava-labs/avalanchego/vms/platformvm/warp" | ||
| "github.com/ava-labs/avalanchego/vms/platformvm/warp/payload" | ||
| "github.com/ava-labs/subnet-evm/warp" | ||
| "google.golang.org/protobuf/proto" | ||
| ) | ||
|
|
||
| var _ p2p.Handler = (*SignatureRequestHandlerP2P)(nil) | ||
|
|
||
| const ( | ||
| ErrFailedToParse = iota | ||
| ErrFailedToGetSig | ||
| ErrFailedToMarshal | ||
| ) | ||
|
|
||
| // SignatureRequestHandlerP2P serves warp signature requests using the p2p | ||
| // framework from avalanchego. It is a peer.RequestHandler for | ||
| // message.MessageSignatureRequest. | ||
| type SignatureRequestHandlerP2P struct { | ||
| backend warp.Backend | ||
| codec codec.Manager | ||
| stats *handlerStats | ||
| } | ||
|
|
||
| func NewSignatureRequestHandlerP2P(backend warp.Backend, codec codec.Manager) *SignatureRequestHandlerP2P { | ||
| return &SignatureRequestHandlerP2P{ | ||
| backend: backend, | ||
| codec: codec, | ||
| stats: newStats(), | ||
| } | ||
| } | ||
|
|
||
| func (s *SignatureRequestHandlerP2P) AppRequest( | ||
| ctx context.Context, | ||
| nodeID ids.NodeID, | ||
| deadline time.Time, | ||
| requestBytes []byte, | ||
| ) ([]byte, *common.AppError) { | ||
| // Per ACP-118, the requestBytes are the serialized form of | ||
| // sdk.SignatureRequest. | ||
| req := new(sdk.SignatureRequest) | ||
| if err := proto.Unmarshal(requestBytes, req); err != nil { | ||
| return nil, &common.AppError{ | ||
| Code: ErrFailedToParse, | ||
| Message: "failed to unmarshal request: " + err.Error(), | ||
| } | ||
| } | ||
|
|
||
| unsignedMessage, err := avalancheWarp.ParseUnsignedMessage(req.Message) | ||
| if err != nil { | ||
| return nil, &common.AppError{ | ||
| Code: ErrFailedToParse, | ||
| Message: "failed to parse unsigned message: " + err.Error(), | ||
| } | ||
| } | ||
| parsed, err := payload.Parse(unsignedMessage.Payload) | ||
| if err != nil { | ||
| return nil, &common.AppError{ | ||
| Code: ErrFailedToParse, | ||
| Message: "failed to parse payload: " + err.Error(), | ||
| } | ||
| } | ||
|
|
||
| var sig [bls.SignatureLen]byte | ||
| switch p := parsed.(type) { | ||
| case *payload.AddressedCall: | ||
| // Note we pass the unsigned message ID to GetMessageSignature since | ||
| // that is what the backend expects. | ||
| // However, we verify the types and format of the payload to ensure | ||
| // the message conforms to the ACP-118 spec. | ||
| sig, err = s.GetMessageSignature(unsignedMessage.ID()) | ||
| if err != nil { | ||
| s.stats.IncMessageSignatureMiss() | ||
| } else { | ||
| s.stats.IncMessageSignatureHit() | ||
| } | ||
| case *payload.Hash: | ||
| sig, err = s.GetBlockSignature(p.Hash) | ||
| if err != nil { | ||
| s.stats.IncBlockSignatureMiss() | ||
| } else { | ||
| s.stats.IncBlockSignatureHit() | ||
| } | ||
| default: | ||
| return nil, &common.AppError{ | ||
| Code: ErrFailedToParse, | ||
| Message: fmt.Sprintf("unknown payload type: %T", p), | ||
| } | ||
| } | ||
| if err != nil { | ||
| return nil, &common.AppError{ | ||
| Code: ErrFailedToGetSig, | ||
| Message: "failed to get signature: " + err.Error(), | ||
| } | ||
| } | ||
|
|
||
| // Per ACP-118, the responseBytes are the serialized form of | ||
| // sdk.SignatureResponse. | ||
| resp := &sdk.SignatureResponse{Signature: sig[:]} | ||
| respBytes, err := proto.Marshal(resp) | ||
| if err != nil { | ||
| return nil, &common.AppError{ | ||
| Code: ErrFailedToMarshal, | ||
| Message: "failed to marshal response: " + err.Error(), | ||
| } | ||
| } | ||
| return respBytes, nil | ||
| } | ||
|
|
||
| func (s *SignatureRequestHandlerP2P) GetMessageSignature(messageID ids.ID) ([bls.SignatureLen]byte, error) { | ||
| startTime := time.Now() | ||
| s.stats.IncMessageSignatureRequest() | ||
|
|
||
| // Always report signature request time | ||
| defer func() { | ||
| s.stats.UpdateMessageSignatureRequestTime(time.Since(startTime)) | ||
| }() | ||
|
|
||
| return s.backend.GetMessageSignature(messageID) | ||
| } | ||
|
|
||
| func (s *SignatureRequestHandlerP2P) GetBlockSignature(blockID ids.ID) ([bls.SignatureLen]byte, error) { | ||
| startTime := time.Now() | ||
| s.stats.IncBlockSignatureRequest() | ||
|
|
||
| // Always report signature request time | ||
| defer func() { | ||
| s.stats.UpdateBlockSignatureRequestTime(time.Since(startTime)) | ||
| }() | ||
|
|
||
| return s.backend.GetBlockSignature(blockID) | ||
| } | ||
|
|
||
| func (s *SignatureRequestHandlerP2P) CrossChainAppRequest( | ||
| ctx context.Context, | ||
| chainID ids.ID, | ||
| deadline time.Time, | ||
| requestBytes []byte, | ||
| ) ([]byte, error) { | ||
| return nil, nil | ||
| } | ||
|
|
||
| func (s *SignatureRequestHandlerP2P) AppGossip( | ||
| ctx context.Context, nodeID ids.NodeID, gossipBytes []byte) { | ||
| } |
Oops, something went wrong.