Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis chainconfig cleanup #1123

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Genesis chainconfig cleanup #1123

merged 7 commits into from
Mar 19, 2024

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Mar 14, 2024

Why this should be merged

1- This adds a new upgrade config networkUpgradeOverrides to override any avalanche network upgrade. With this upgrade config and skip-upgrade-check flag set to true, one can modify the timestamp of activated upgrade. This will come handy if a subnet has missed the upgrade (failed to update nodes) and as a result their chain has become unsyncable with newer versions. In this case networkUpgradeOverrides can be used to set a later time for upgrades. I.e:
upgrade.json:

{
  "networkUpgradeOverrides": {
    "durangoTimestamp": 1710415083
  }
}

2- Default Network Upgrades are introduced. nil and blank values in network upgrades (eth forks + avalanche upgrades) will now default to values. Meaning that it won't be possible to deactivate an existing upgrade via nil values.

3- This PR also removes OptionalNetworkUpgrades since now we can modify all NetworkUpgrades.

How this was tested

Unit tests + local tests

How is this documented

it will be documented in docs repo.

@ceyonur ceyonur self-assigned this Mar 14, 2024
@ceyonur ceyonur requested a review from darioush as a code owner March 14, 2024 12:06
@ceyonur ceyonur requested a review from aaronbuchwald March 14, 2024 12:06
params/config.go Show resolved Hide resolved
params/network_upgrades.go Show resolved Hide resolved
params/network_upgrades.go Outdated Show resolved Hide resolved
params/network_upgrades.go Outdated Show resolved Hide resolved
@ceyonur ceyonur requested a review from marun March 14, 2024 12:20
params/network_upgrades.go Outdated Show resolved Hide resolved
params/network_upgrades.go Outdated Show resolved Hide resolved
core/state_processor.go Show resolved Hide resolved
plugin/evm/vm_test.go Show resolved Hide resolved
@ceyonur ceyonur linked an issue Mar 18, 2024 that may be closed by this pull request
@ceyonur ceyonur enabled auto-merge (squash) March 19, 2024 14:18
@ceyonur ceyonur merged commit eeb2cd5 into master Mar 19, 2024
10 checks passed
@ceyonur ceyonur deleted the genesis-chainconfig-cleanup branch March 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Genesis ChainConfig Timestamp Cleanup
3 participants