-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign validator uptime warp msg #1367
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs/subnet-evm into always-sign-uptime
…va-labs/subnet-evm into sign-validator-uptime-warp-msg
michaelkaplan13
previously approved these changes
Nov 13, 2024
…subnet-evm into sign-validator-uptime-warp-msg
ceyonur
removed
the
DO NOT MERGE
This PR is not meant to be merged in its current state
label
Nov 13, 2024
ceyonur
dismissed stale reviews from michaelkaplan13 and darioush
November 13, 2024 22:23
The base branch was changed.
michaelkaplan13
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new features and improvements to the
warp
package, including the addition of a new example application, a no-op state implementation, and enhanced validator state management. The changes also include updates to the backend and verifier components to support the new functionalities.Added support for verifying offchain addressed call messages in the
verifier_backend
(warp/verifier_backend.go
). [1] [2]Updated imports and added necessary dependencies for the new verification logic (
warp/verifier_backend.go
,warp/verifier_backend_test.go
). [1] [2] [3]Added a new example application demonstrating how to request a signature for an uptime message from a locally running node (
examples/sign-uptime-message/main.go
).Updated the
backend
struct and related functions to includeuptimeCalculator
,validatorState
, andstateLock
for improved state management (warp/backend.go
). [1] [2] [3]Modified backend initialization in tests to include the new state management parameters (
warp/backend_test.go
). [1] [2] [3] [4] [5]Validator State Management:
plugin/evm/validators/interfaces/noop_state.go
).Miscellaneous:
warp/handlers/signature_request_test.go
). [1] [2]Signable
interface from thewarp/messages/payload.go
file.warp/messages/validator_uptime.go
).These changes collectively enhance the functionality and maintainability of the
warp
package, particularly in terms of state management and message verification.How this was tested
Added UTs
How is this documented
Not sure if we have any warp types docs.