Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign validator uptime warp msg #1367

Merged
merged 157 commits into from
Nov 13, 2024
Merged

Sign validator uptime warp msg #1367

merged 157 commits into from
Nov 13, 2024

Conversation

ceyonur
Copy link
Collaborator

@ceyonur ceyonur commented Oct 17, 2024

This pull request introduces several new features and improvements to the warp package, including the addition of a new example application, a no-op state implementation, and enhanced validator state management. The changes also include updates to the backend and verifier components to support the new functionalities.

  • Added support for verifying offchain addressed call messages in the verifier_backend (warp/verifier_backend.go). [1] [2]

  • Updated imports and added necessary dependencies for the new verification logic (warp/verifier_backend.go, warp/verifier_backend_test.go). [1] [2] [3]

  • Added a new example application demonstrating how to request a signature for an uptime message from a locally running node (examples/sign-uptime-message/main.go).

  • Updated the backend struct and related functions to include uptimeCalculator, validatorState, and stateLock for improved state management (warp/backend.go). [1] [2] [3]

  • Modified backend initialization in tests to include the new state management parameters (warp/backend_test.go). [1] [2] [3] [4] [5]

Validator State Management:

  • Implemented a no-op state for validators, providing stub methods for state operations (plugin/evm/validators/interfaces/noop_state.go).

Miscellaneous:

  • Updated various test files to accommodate the new state management and verification logic (warp/handlers/signature_request_test.go). [1] [2]
  • Removed unused Signable interface from the warp/messages/payload.go file.
  • Added comments and minor adjustments to existing code for clarity and consistency (warp/messages/validator_uptime.go).

These changes collectively enhance the functionality and maintainability of the warp package, particularly in terms of state management and message verification.

How this was tested

Added UTs

How is this documented

Not sure if we have any warp types docs.

@michaelkaplan13 michaelkaplan13 self-requested a review November 12, 2024 21:31
@ceyonur ceyonur removed the DO NOT MERGE This PR is not meant to be merged in its current state label Nov 13, 2024
Base automatically changed from uptime-tracking-api to master November 13, 2024 22:23
@ceyonur ceyonur dismissed stale reviews from michaelkaplan13 and darioush November 13, 2024 22:23

The base branch was changed.

@ceyonur ceyonur enabled auto-merge (squash) November 13, 2024 22:33
@ceyonur ceyonur merged commit f1d549c into master Nov 13, 2024
14 checks passed
@ceyonur ceyonur deleted the sign-validator-uptime-warp-msg branch November 13, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants