Pausable uptime manager

[ceyonur]

Why this should be merged

Adds pausable uptime manager interface for uptime tracking

How this works

Pausable uptime manager extends the avalanchego uptime manager by introducing callback listeners for validators state (under plugin/evm/validators). The idea is to pause a node's uptime and then can continue whenever it's resumed. It also modifies Connect, Disconnect, StartTracking` accordingly.

How this was tested

Added tests

How is this documented

Comments in code

[michaelkaplan13]

Could you confirm my understanding based on going through this code in the context of ACP-77?

• Validators can are either connected/disconnected and active/inactive.
  • A connected & inactive validator represents a validators running properly, but out of PAYG on the P-Chain
  • A connected & active validator is both running properly and has non-zero balance on the P-Chain
  • A disconnected & active validator represents an offline node that still has non-zero balance on the P-Chain
  • A disconnected & inactive validator is a node that is both offline and out of PAYG balance.
• We pause nodes when they are marked as inactive, and when we pause them, we disconnect from them if we were previously connected.
• We resume nodes when they are marked as active, and reconnect to them then if necessary.
• A nodes uptime is incremented when: (it is both active and connected) OR (it isn't tracked). The second part is because we assume validators are online while we ourselves are offline.

[ceyonur]

Could you confirm my understanding based on going through this code in the context of ACP-77?

* Validators can are either connected/disconnected and active/inactive.

Yes, those two states are different though. They can be connected/active disconnected/inactive etc...

  * A connected & inactive validator represents a validators running properly, but out of PAYG on the P-Chain

True

  * A connected & active validator is both running properly and has non-zero balance on the P-Chain

True

  * A disconnected & active validator represents an offline node that still has non-zero balance on the P-Chain

True

  * A disconnected & inactive validator is a node that is both offline and out of PAYG balance.

True

* We pause nodes when they are marked as inactive, and when we pause them, we disconnect from them if we were previously connected.

True, the inner manager (who does the actual uptime tracking) is disconnected.

* We resume nodes when they are marked as active, and reconnect to them then if necessary.

True. Note that they're already connected (in p2p), we just start increasing their uptime in manager.

* A nodes uptime is incremented when: (it is both active and connected) OR (it isn't tracked). The second part is because we assume validators are online while we ourselves are offline.

true