chore(scripts): simplify mock.gen.sh to use go generate commands
#1413
+32
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
changed the title
mock.gen.sh to use go generate commands
qdm12
force-pushed
the
qdm12/mock-gen-script
branch
from
3edebbc to
a37996e
Compare
ceyonur
reviewed
Dec 28, 2024
ceyonur
reviewed
Dec 30, 2024
ceyonur
reviewed
Dec 30, 2024
There was a problem hiding this comment.
do we have any sibling PR for avalanchego? This is a direct copy from avalanchego. I'd prefer to keep workflows in repos (coreth/subnet-evm/avalanchego) as similar as possible.
- Add missing license headers - Localized mockgen commands in the package where they are needed - Less shell scripting needed - Remove unneeded `source` commands for constants.sh and versions.sh
qdm12
force-pushed
the
qdm12/mock-gen-script
branch
from
6517376 to
32b875c
Compare
qdm12
force-pushed
the
qdm12/mock-gen-script
branch
from
0c66511 to
b001446
Compare
(Note using source mode was compulsory due to CGO)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
💁 Sibling PR for coreth so both repositories would look similar in this aspect
sourcecommands for constants.sh and versions.shHow this works
mocks_generate_test.gofile per package where mocks need to be generated, containing only//go:generate mockgencommands. Each command is relative to the current package directoryscripts/mocks.gen.shand remove now unneededscripts/mocks.mockgen.txtHow this was tested
./scripts/mocks.gen.shNeed to be documented?
No
Need to update RELEASES.md?
Not really