Invalidate block when missing predicate context #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
requested review from
ceyonur,
darioush and
aaronbuchwald
as code owners
ceyonur
approved these changes
Sep 27, 2023
darioush
approved these changes
Sep 27, 2023
dhrubabasu
approved these changes
Sep 27, 2023
Signed-off-by: aaronbuchwald <aaron.buchwald56@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Verification of a predicate requires a the predicate context. If the predicate context is missing, we should invalidate the whole block rather than marking the result of the predicate as failed.
How this works
Moves the check out of the warp package and into the core package.
How this was tested
CI
How is this documented
With a comment