New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): use a real setting by default #61

Open

damienwebdev wants to merge 1 commit into avadev:master from damienwebdev:user_space_to_misbahave

damienwebdev commented Oct 15, 2022

If a change results in user programs breaking, it's a bug in the
kernel. We never EVER blame the user programs. How hard can this be to
understand?

This plugin breaks deployments of existing Avatax Magento 2 instances unless this setting is pre-set to 0 or 1.

This has now caused two separate outages where tax was not charged to customers.

This isn't a "read the fine print situtation". This is a "we broke your codebase" situation.

This patch corrects the issue.


          fix(config): use a real setting by default

6e5507f

lbajsarowicz commented Oct 25, 2022

@virtual97 Is your team able to address that?

ihor-sviziev approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet