Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use is-equal instead of deeper for es6 set and map support #409

Closed
wants to merge 1 commit into from
Closed

use is-equal instead of deeper for es6 set and map support #409

wants to merge 1 commit into from

Conversation

mayankchd
Copy link

No description provided.

@mayankchd
Copy link
Author

Failing on Node.js 0.10 as it doesn't support Set and Map

@jamestalmage
Copy link
Contributor

For Node 0.10, lookup how Set and Map are referenced when transformed by Babel, should be something like:

var Map = require('babel-runtime/lib/fn/Map');
// or 
var Map = require('core-js/lib/fn/Map');

@sindresorhus
Copy link
Member

I would prefer to just add support for Map/Set in deeper. is-equal brings in 2.3 MB of dependencies.

@sindresorhus
Copy link
Member

Closing in favor of othiym23/node-deeper#2.

@jamestalmage
Copy link
Contributor

👍 I agree. 2.3MB is just way to big. AVA already takes just this side of eternity to download. @twada and others have put in major effort slimming down their packages and our download size. This would be a major step in the wrong direction.

Sorry @mayankchd. Otherwise your PR looked great. It's not your fault that package is so bloated.

@mayankchd
Copy link
Author

Thanks! I like ava a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants