make Transaction and Message immutable #156
Open
+409
−340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiyarmir
force-pushed
the
guillermo/make-transaction-and-signedtransaction-immutable
branch
from
547d290
to
cc54dbb
Compare
Dependency ReviewThe following issues were found:
License Issuessettings.gradle.kts
OpenSSF Scorecard
Scanned Files
|
also tries to cleanup a bit the serialisation logic
wiyarmir
force-pushed
the
guillermo/make-transaction-and-signedtransaction-immutable
branch
from
cc54dbb
to
cc04ae7
Compare
jszmltr
reviewed
Nov 8, 2024
| public var recentBlockHash: String? = null, | ||
| accountKeys: AccountKeysList = AccountKeysList(), | ||
| instructions: List<TransactionInstruction> = emptyList(), | ||
| public class Message internal constructor( |
There was a problem hiding this comment.
Should we add a equals and hashcode here ?
| ) { | ||
|
|
||
| val bytes: Int | ||
| get() = |
There was a problem hiding this comment.
Is the formatting ok here ? 🤔
| } | ||
| } | ||
|
|
||
| override fun toString(): String = |
There was a problem hiding this comment.
We need a hashcode here to I think
| @@ -3,8 +3,10 @@ package net.avianlabs.solana.vendor | |||
| import okio.Buffer | |||
| import kotlin.experimental.and | |||
|
|
|||
| internal typealias ShortVecLength = ByteArray | |||
|
|
|||
| internal object ShortvecEncoding { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also tries to cleanup a bit the serialisation logic