Fix useHookstate store switchover #409
Open
+131
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speigg
force-pushed
the
fix-InitStateStoreSwitchover
branch
from
afb51ed
to
f506584
Compare
speigg
force-pushed
the
fix-InitStateStoreSwitchover
branch
from
ac337e2
to
139b9e2
Compare
avkonst
reviewed
May 24, 2024
|
|
||
| rerender({ source: newStore }); | ||
|
|
||
| expect(renderTimes).toBe(3); |
There was a problem hiding this comment.
could you please extend the tests to make sure we can do state set action after the store is reinitialized? same for other tests you put.
| @@ -1056,7 +1066,8 @@ class Store implements Subscribable { | |||
| set(path: Path, value: StateValueAtPath): SetActionDescriptor { | |||
| if (this.edition < 0) { | |||
| // TODO convert to console log | |||
There was a problem hiding this comment.
maybe remove TODO comment? and update web docs for this error code?
|
Hi @speigg ... could you please let me know if you are planning to address my comments? |
|
Hi @avkonst I'd be happy to address your comments as soon as I have finished taking care of other things on my plate. Might take me another week to get to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for store switchovers to useHookstate() for global and nested state. Local state behavior remains unchanged. Additionally, setting state after unmount no longer throws an error, which is more in line w/ how React's built-in useState hook works.
TLDR; Eliminated HOOKSTATE-111 and HOOKSTATE-106 exceptions.
closes #364