Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: media library/gallery #3561

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Dec 29, 2024

Description

Fixes #2073

This PR adds two features:

1. Media Library enables users to browse all the Active Storage attachments and update them.

2. Gallery for Trix and Rhino fields which enables a user to inject attachments in the body of the editor. The user can inject multiple files at once.

Screenshots

  1. Media Library
CleanShot.2024-12-29.at.16.05.01.mp4
  1. WYSIWYG Gallery
CleanShot.2024-12-29.at.16.06.00.mp4

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Still to do:

  • settle on controllers
  • make pagination work on field gallery mode
  • Improve modal styling (check if it looks good on field gallery mode)
  • remove the "side-view" for the initial iteration. it was previously implemented but abandoned
  • if attachments are disabled, the media library button is hidden in Trix field. That should be visible IMHO
  • check other types of files (other than images)
    • check the representable support

Second iteration:

  • Add "dropzone" style box to drop files in the gallery
  • add search
  • add filters

@adrianthedev adrianthedev added Task Something to get done 😎 Cool labels Dec 29, 2024
Copy link

codeclimate bot commented Dec 29, 2024

Code Climate has analyzed commit 2bd7d85 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😎 Cool Feature Task Something to get done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant