utils/cpu: Check cpu list for s390x [v5] #2361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output in /proc/cpuinfo is different between s390x and other archs. This is to support to parse the output on s390x. Signed-off-by: Dan Zheng <dzheng@redhat.com> Signed-off-by: Cleber Rosa <crosa@redhat.com>
This simple test, after the s390x version, checks the proper parsing of and x86_64 /proc/cpuinfo. Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
get_cpu_online_map_v5
branch
from
0a2d5a3 to
82099a0
Compare
apahim
reviewed
Dec 15, 2017
| issue = json.load(download.url_open(issue_url)) | ||
| self.assertEqual(issue['state'], 'open', 'The issue %s is not open ' | ||
| 'anymore. Please double check and, if already fixed, ' | ||
| 'remote the selftests/unit/test_utils_cpu.py from ' |
There was a problem hiding this comment.
oops, my bad. Fixing it.
apahim
reviewed
Dec 15, 2017
There was a problem hiding this comment.
@clebergnu could you please just update with the typo fix? then we will be ready to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output in /proc/cpuinfo is different between s390x and other archs.
This is to support to parse the output on s390x.
Signed-off-by: Dan Zheng dzheng@redhat.com
Signed-off-by: Cleber Rosa crosa@redhat.com
Changes from v4 (#2357):
Changes from v3 (#2353):
Changes from v2 (#2351):
Changes from v1 (#2300):
/proc/cpuinfoon s390x