Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MorphMany relationships in CuratorPicker #485

Merged
merged 4 commits into from
May 26, 2024

Conversation

abbasmashaddy72
Copy link
Contributor

This PR introduces the following enhancements:

  • Adds support for MorphMany relationships in the CuratorPicker component.
  • Implements methods for state hydration and saving for MorphMany relationships.
  • Handles related media data retrieval, with conditional filtering based on type if specified.
  • Updates the getRelationship and saveRelationshipsUsing methods to manage MorphMany relationships, including ordering.
  • Adds optional typeColumn and typeValue support for more flexible data handling.

Note: The current implementation supports morphable relationships in forms, but it is not yet functional in table columns. Further adjustments are required for full compatibility.

@abbasmashaddy72
Copy link
Contributor Author

Issues Fixed:

  • Ensured that the order is correctly incremented based on the type of the media item.
  • Resolved the issue where new items were not getting the correct order value.
  • Added logic to delete items only of the specific type that are no longer present in the new state.

Message:

If any issues arise while testing, let me know. I am already testing it.

@awcodes awcodes merged commit b50c315 into awcodes:3.x May 26, 2024
1 check passed
@awcodes
Copy link
Owner

awcodes commented May 26, 2024

Thanks. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants