Minlopro: refactoring scratch generation scripts

awesomeandrey · Nov 19, 2024 · 0c9328a · 0c9328a
1 parent 854131a
commit 0c9328a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.github/workflows/create_crma_scratch_org.yml b/.github/workflows/create_crma_scratch_org.yml
@@ -48,6 +48,7 @@ jobs:
           # Initiate CRMA scratch org generation
           bash ./scripts/automations/create_crma_scratch_org.sh < $inputsFile
       - name: 'Upload Scratch Org Credentials as Artifact'
+        if: ${{ success() && github.event.inputs.purgeOnCreate == 'false' }}
         uses: actions/upload-artifact@v4
         with:
           name: minlopro-crma-scratch-org-credentials

diff --git a/.github/workflows/create_scratch_org.yml b/.github/workflows/create_scratch_org.yml
@@ -38,6 +38,7 @@ jobs:
           bash ./scripts/deploy/authorize_org.sh --sfdxUrl "$DEV_HUB_AUTH_URL" --orgAlias "DevHub"
           sf config set target-dev-hub=DevHub
       - name: 'Spin Up Brand New Scratch Org'
+        continue-on-error: true
         run: |
           inputsFile="inputs.txt"
           touch $inputsFile
@@ -50,6 +51,7 @@ jobs:
           # Initiate scratch org generation
           bash ./scripts/automations/create_scratch_org.sh < $inputsFile
       - name: 'Upload Scratch Org Credentials as Artifact'
+        if: ${{ success() && github.event.inputs.purgeOnCreate == 'false' }}
         uses: actions/upload-artifact@v4
         with:
           name: minlopro-scratch-org-credentials
@@ -59,6 +61,7 @@ jobs:
           if-no-files-found: error
           retention-days: 5
       - name: 'Run Apex Tests With Coverage'
+        continue-on-error: true
         if: ${{ success() && github.event.inputs.runApexTests == 'true' }}
         run: npm run sf:apex:tests:coverage -- --target-org "ScratchOrg"
       - name: 'Purge Scratch Org'