Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #12

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Main #12

merged 3 commits into from
Aug 26, 2024

Conversation

mulaga
Copy link
Collaborator

@mulaga mulaga commented Aug 23, 2024

added a fill method that works with matrices. apply is still overloaded to work with both columns and matrices since this seems to be a design decision with the State class.

i also added some docs for this functionality and tests with each block type.

@awietek
Copy link
Owner

awietek commented Aug 23, 2024

Thank you Martin, that's a great new feature to have. It does seem as if on Linux, the continuous integration testing has some undefined references when it tries to compile. I realize this is whenever the matrix is complex. Are these functions defined, or maybe a template instantiation is missing?

@awietek
Copy link
Owner

awietek commented Aug 23, 2024

Looking a bit more closely, it indeed seems you just missed the template instantiation for complex matrices, i.e. you only added e.g.:

template void apply(OpSum const &, Electron const &,
arma::Mat const &, Electron const &,
arma::Mat &, double);

but not

template void apply(OpSum const &, Electron const &,
arma::Mat const &, Electron const &,
arma::Mat &, double);

@mulaga
Copy link
Collaborator Author

mulaga commented Aug 26, 2024

i guess the compiler defaulted to weak symbols which don't work on all architectures. not sure that I completely understand the behaviour, but I seem to have missed it since it compiled fine on several computers.

@awietek awietek merged commit 65e51f9 into awietek:main Aug 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants