Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppSync_BreakingChangeDetection hook to release pipeline #244

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Conversation

ndejaco2
Copy link
Contributor

@ndejaco2 ndejaco2 commented Oct 12, 2023

Description of changes:

  • This change adds AppSync_BreakingChangeDetection hook to the awscommunity registry pipeline.
  • The cloudformation cli plugin for java and other languages now requires python >= 3.8. I went ahead and bumped this to unblock other resources in this pipeline.
  • 1 known issue is that the resources written in go are unable to succeed due to the following error, which will be fixed later:
File "/root/.pyenv/versions/3.8.13/lib/python3.8/site-packages/rpdk/core/cli.py", line 105, in main
    args.command(args)
  File "/root/.pyenv/versions/3.8.13/lib/python3.8/site-packages/rpdk/core/validate.py", line 14, in validate
    project.load()
  File "/root/.pyenv/versions/3.8.13/lib/python3.8/site-packages/rpdk/core/project.py", line 551, in load
    self.load_settings()
  File "/root/.pyenv/versions/3.8.13/lib/python3.8/site-packages/rpdk/core/project.py", line 230, in load_settings
    self.validate_and_load_resource_settings(raw_settings)
  File "/root/.pyenv/versions/3.8.13/lib/python3.8/site-packages/rpdk/core/project.py", line 278, in validate_and_load_resource_settings
    self._plugin = load_plugin(raw_settings["language"])
  File "/root/.pyenv/versions/3.8.13/lib/python3.8/site-packages/rpdk/core/plugin_registry.py", line 36, in load_plugin
    return PLUGIN_REGISTRY[language]()()
KeyError: 'go'

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ericzbeard ericzbeard merged commit 33664cc into aws-cloudformation:main Oct 12, 2023
96 of 150 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants