Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reject invalid thing group names #184

Merged
merged 3 commits into from
Aug 22, 2024
Merged

fix: reject invalid thing group names #184

merged 3 commits into from
Aug 22, 2024

Conversation

jcosentino11
Copy link
Member

Issue #, if available:

Description of changes:

Reject create deployment requests that contain an invalid thing group name (e.g. contains a :).

Why is this change necessary:

How was this change tested:
Server tests added

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

alter-mage
alter-mage previously approved these changes Aug 22, 2024
Copy link

Client Coverage Report

File Coverage Lines Branches
All files 63% 58% 68%
com.aws.greengrass.cli.module.AdapterModule 100% 100% 0%
com.aws.greengrass.cli.module.LogsModule 75% 75% 0%
com.aws.greengrass.cli.module.VersionProvider 13% 13% 0%
com.aws.greengrass.cli.util.FileUtils 0% 0% 0%
com.aws.greengrass.cli.util.FileUtils$1 0% 0% 0%
com.aws.greengrass.cli.util.PlatformUtils 0% 0% 0%
com.aws.greengrass.cli.adapter.impl.NucleusAdapterIpcClientImpl$SubscriptionMqttResponseHandler 0% 0% 0%
com.aws.greengrass.cli.adapter.impl.NucleusAdapterIpcClientImpl 6% 4% 9%
com.aws.greengrass.cli.adapter.impl.NucleusAdapterIpcClientImpl$SubscriptionResponseHandler 0% 0% 0%
com.aws.greengrass.cli.adapter.impl.NucleusAdapterIpcClientImpl$1 0% 0% 0%
com.aws.greengrass.cli.commands.topic.PubSubCommand 60% 71% 50%
com.aws.greengrass.cli.commands.topic.IotCoreCommand 60% 71% 50%
com.aws.greengrass.cli.commands.topic.TopicBaseInfo 59% 68% 50%
com.aws.greengrass.cli.CommandFactory 71% 71% 0%
com.aws.greengrass.cli.CLI 13% 13% 0%
com.aws.greengrass.cli.util.logs.LogFile 82% 90% 75%
com.aws.greengrass.cli.util.logs.FileReader 91% 85% 96%
com.aws.greengrass.cli.util.logs.LogEntry 91% 95% 87%
com.aws.greengrass.cli.util.logs.LogsUtil 92% 92% 0%
com.aws.greengrass.cli.util.logs.LogQueue 76% 85% 66%
com.aws.greengrass.cli.util.logs.impl.VisualizationImpl 89% 97% 81%
com.aws.greengrass.cli.util.logs.impl.FilterImpl 96% 100% 93%
com.aws.greengrass.cli.util.logs.impl.AggregationImpl 93% 98% 87%
com.aws.greengrass.cli.util.logs.impl.AggregationImplConfig 93% 93% 0%
com.aws.greengrass.cli.util.logs.impl.FilterImpl$FilterEntry 100% 100% 0%
com.aws.greengrass.cli.commands.PasswordCommand 16% 16% 0%
com.aws.greengrass.cli.commands.Logs 98% 96% 100%
com.aws.greengrass.cli.commands.BaseCommand 20% 20% 0%
com.aws.greengrass.cli.commands.ComponentCommand 100% 100% 100%
com.aws.greengrass.cli.commands.DeploymentCommand 51% 56% 47%

Minimum allowed coverage is 65%

Generated by 🐒 cobertura-action against 4a67f70

Copy link

Server Coverage Report

File Coverage Lines Branches
All files 71% 89% 53%
com.aws.greengrass.cli.CLIEventStreamAgent 87% 94% 80%
com.aws.greengrass.cli.CLIEventStreamAgent$ListLocalDeploymentsHandler 73% 96% 50%
com.aws.greengrass.cli.CLIEventStreamAgent$RestartComponentsHandler 98% 96% 100%
com.aws.greengrass.cli.CLIEventStreamAgent$CreateDebugPasswordHandler 91% 91% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$CreateLocalDeploymentHandler 85% 85% 85%
com.aws.greengrass.cli.CLIEventStreamAgent$GetLocalDeploymentStatusHandler 91% 96% 85%
com.aws.greengrass.cli.CLIEventStreamAgent$StopComponentHandler 96% 96% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$ListComponentsHandler 97% 94% 100%
com.aws.greengrass.cli.CLIService$LocalDeploymentDetails 0% 0% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$LocalDeploymentDetails 76% 76% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$GetComponentDetailsHandler 96% 96% 0%
com.aws.greengrass.cli.CLIEventStreamAgent$CancelLocalDeploymentHandler 76% 85% 66%
com.aws.greengrass.cli.CLIService 75% 85% 65%

Minimum allowed coverage is 58%

Generated by 🐒 cobertura-action against 4a67f70

@saranyailla saranyailla merged commit 21bc20c into main Aug 22, 2024
4 checks passed
@saranyailla saranyailla deleted the validations branch August 22, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants