feat: cda work queue #132
Open
feat: cda work queue #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbutler
commented
Sep 21, 2022
| @@ -156,6 +157,8 @@ void GIVEN_brokerWithValidCredentials_WHEN_GetClientDeviceAuthToken_THEN_returns | |||
| } | |||
| } | |||
|
|
|||
| // TODO: Re-enable once infrastructure supports limiting queue size | |||
| @Disabled | |||
There was a problem hiding this comment.
Need to sort out how this should work moving forward
jbutler
force-pushed
the
work-queue
branch
2 times, most recently
from
ea84697
to
3e7c8b3
Compare
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against d264ae1 |
jbutler
commented
Sep 22, 2022
| public final class InfrastructureConfiguration { | ||
| public static final int DEFAULT_WORK_QUEUE_DEPTH = 100; | ||
| public static final int DEFAULT_THREAD_POOL_SIZE = 1; | ||
|
|
There was a problem hiding this comment.
I don't love this configuration - might make sense to re-organize a bit. But for now, we'll keep it how it is.
Note: I didn't want to change the existing SessionConfig, so this performance key is split between the two config classes. I don't love it, but I also wanted to keep this PR as contained as possible.
jbutler
commented
Sep 22, 2022
| public void shutdown() { | ||
| executor.shutdown(); | ||
| } | ||
|
|
There was a problem hiding this comment.
I'll like add methods for scheduling tasks in the future. We'll need to replace the queue with a delay queue for that. That can come later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
[WIP] Introduces work queue as infrastructure. This can be injected to other classes and used to queue async jobs
Why is this change necessary:
This simplifies queuing of work that must happen in another thread context. It also enables scheduling jobs in the future.
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.