feat: recover from configuration failures #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nelsonochoam
force-pushed
the
configuration-error-handling
branch
from
cf514c0
to
bf0b38e
Compare
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against d88c097 |
jbutler
reviewed
Oct 5, 2022
| private CDAConfiguration cdaConfiguration; | ||
| private volatile boolean configurationErrored = false; |
There was a problem hiding this comment.
I'm not sure if this is necessary at all, but future reference, you could just synchronize on configurationErrored instead and then you also don't need volatile
Comment on lines
+146
to
+147
| // service to error, but we don't want to check again until the nucleus has run the remediation steps (when the | ||
| // service errors, the nucleus will try to call shutdown -> install -> startup). |
There was a problem hiding this comment.
Can you help me understand this? My mental model is that we shouldn't need to care about what Nucleus is doing, and that we can rely entirely on configuration updates. If we are broken, and a configuration change fixes us, then request reinstall? Are there scenarios where that will not work?
There was a problem hiding this comment.
Right, it should be possible to make this as simple as, on config change, if state is broken, then request reinstall.
There was a problem hiding this comment.
@jbutler and I chatted about this offline - we are going to dig deeper and see if it is required
Comment on lines
+219
to
+224
| synchronized (configLock) { | ||
| if (configurationErrored) { | ||
| configurationErrored = false; | ||
| onConfigurationChanged(); | ||
| } | ||
| } |
There was a problem hiding this comment.
I thought the issue was that if we are broken, then Nucleus doesn't call startup?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Enables CDA to recover from certificateAuthority configuration failures with requiring a manual restart.
Why is this change necessary:
Without this when a customer provides a bad config the component will error and can't recover without un installing and re installing
How was this change tested:
Integration test