-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate config and error service during startup #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDombo
previously approved these changes
Feb 20, 2024
jcosentino11
previously approved these changes
Feb 20, 2024
src/integrationtests/java/com/aws/greengrass/integrationtests/policy/PolicyTest.java
Outdated
Show resolved
Hide resolved
src/integrationtests/java/com/aws/greengrass/integrationtests/policy/PolicyTest.java
Outdated
Show resolved
Hide resolved
robcmann
dismissed stale reviews from jcosentino11 and MikeDombo
via
February 20, 2024 21:09
02c53de
Benchmark Results
|
MikeDombo
approved these changes
Feb 20, 2024
jcosentino11
approved these changes
Feb 20, 2024
Code Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 02c53de |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Validate CDA config during startup and force CDA to error if a validation exception is thrown.
Why is this change necessary:
Without this change, CDA will not reach the broken state when there is a bad config.
How was this change tested:
Integration testing
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.