chore(deps): rebase moquette on 0.17 release #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeDombo
commented
Sep 14, 2023
moquette-0.17/broker/src/main/java/io/moquette/broker/BrokerConfiguration.java
Show resolved
Hide resolved
moquette-0.17/broker/src/main/java/io/moquette/broker/Server.java
Outdated
Show resolved
Hide resolved
moquette-0.17/broker/src/main/java/io/moquette/broker/unsafequeues/QueuePool.java
Show resolved
Hide resolved
moquette-0.17/broker/src/main/java/io/moquette/broker/Server.java
Outdated
Show resolved
Hide resolved
moquette-0.17/broker/src/main/java/io/moquette/broker/unsafequeues/QueuePool.java
Show resolved
Hide resolved
moquette-0.17/broker/src/main/java/io/moquette/broker/subscriptions/CTrie.java
Show resolved
Hide resolved
moquette-0.17/broker/src/main/java/io/moquette/broker/unsafequeues/QueuePool.java
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
MikeDombo
force-pushed
the
moq-17
branch
2 times, most recently
from
27a8f1a to
b955755
Compare
MikeDombo
commented
Sep 14, 2023
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against bcc368e |
|
Working on getting Windows tests passing. Moquette doesn't properly close all file handles, so it then cannot delete the tempdir used by tests. |
jcosentino11
approved these changes
Sep 14, 2023
moquette-0.17/broker/src/test/java/io/moquette/integration/IntegrationUtils.java
Fixed
Show fixed
Hide fixed
moquette-0.17/broker/src/test/java/io/moquette/integration/IntegrationUtils.java
Dismissed
Show dismissed
Hide dismissed
MikeDombo
force-pushed
the
moq-17
branch
3 times, most recently
from
b3c7dc0 to
e0ae0c3
Compare
...test/java/io/moquette/integration/ServerIntegrationPahoCanPublishOnReadBlockedTopicTest.java
Dismissed
Show dismissed
Hide dismissed
...te-0.17/broker/src/test/java/io/moquette/integration/ServerIntegrationSSLClientAuthTest.java
Dismissed
Show dismissed
Hide dismissed
...te-0.17/broker/src/test/java/io/moquette/integration/ServerIntegrationSSLClientAuthTest.java
Dismissed
Show dismissed
Hide dismissed
moquette-0.17/broker/src/test/java/io/moquette/integration/ServerIntegrationSSLTest.java
Dismissed
Show dismissed
Hide dismissed
moquette-0.17/broker/src/test/java/io/moquette/integration/ServerIntegrationSSLTest.java
Dismissed
Show dismissed
Hide dismissed
moquette-0.17/broker/src/test/java/io/moquette/integration/ServerIntegrationOpenSSLTest.java
Dismissed
Show dismissed
Hide dismissed
moquette-0.17/broker/src/test/java/io/moquette/integration/ServerIntegrationOpenSSLTest.java
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Update to the released version of 0.17, keeping our specific changes for Greengrass and removing the telemetry added by moquette.
Why is this change necessary:
How was this change tested:
Existing tests are passing including integration. Further testing will happen in the pipelines.
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.