Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to moquette 0.17 release version #123

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

MikeDombo
Copy link
Member

@MikeDombo MikeDombo commented Sep 14, 2023

Issue #, if available:

Description of changes:
Update to the released version of 0.17, keeping our specific changes for Greengrass and removing the telemetry added by moquette.

This change is split into 2 commits. The first commit wipes out our version of moquette 0.16 and replaces it entirely with the released version of 0.17. The next commit then applies only the customizations that we want which would hopefully make future rebases easier. To keep the history nice, do a rebase merge with this PR -- do not squash it.

Why is this change necessary:

How was this change tested:
Existing tests are passing including integration. Further testing will happen in the pipelines.

Any additional information or context required to review the change:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

Unit Tests Coverage Report

File Coverage Lines Branches
All files 68% 74% 62%
com.aws.greengrass.mqtt.moquette.GreengrassMoquetteSslContextCreator 51% 60% 41%
com.aws.greengrass.mqtt.moquette.ClientDeviceAuthorizer 80% 79% 81%
com.aws.greengrass.mqtt.moquette.ClientDeviceTrustManager 95% 90% 100%
com.aws.greengrass.mqtt.moquette.MQTTService 76% 81% 71%
com.aws.greengrass.mqtt.moquette.BrokerKeyStore 64% 64% 0%
com.aws.greengrass.mqtt.moquette.ClientDeviceAuthorizer$ConnectionTerminationListener 62% 73% 50%
com.aws.greengrass.mqtt.moquette.ClientDeviceAuthorizer$UserSessionPair 100% 100% 0%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 676c342

@MikeDombo MikeDombo marked this pull request as ready for review September 14, 2023 19:35
@MikeDombo MikeDombo merged commit fdb7b0f into main Sep 14, 2023
4 checks passed
@MikeDombo MikeDombo deleted the moq-17-clean-history branch September 14, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants