fix: move pkcs11 initialization into plugin startup instead of install (

#37)
aws-greengrass · Jul 25, 2023 · b982d65 · b982d65
1 parent 946d5e5
commit b982d65
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/main/java/com/aws/greengrass/security/provider/pkcs11/PKCS11CryptoKeyService.java b/src/main/java/com/aws/greengrass/security/provider/pkcs11/PKCS11CryptoKeyService.java
@@ -167,13 +167,14 @@ protected void install() throws InterruptedException {
             throw new RuntimeException(String.format("Failed to install PKCS11CryptoKeyService. "
                     + "Make sure that configuration format for %s service is valid.", PKCS11_SERVICE_NAME));
         }
-        if (!initializePkcs11Lib() || !initializePkcs11Provider()) {
-            serviceErrored("Can't initialize PKCS11");
-        }
     }
 
     @Override
     protected void startup() throws InterruptedException {
+        if (!initializePkcs11Lib() || !initializePkcs11Provider()) {
+            serviceErrored("Can't initialize PKCS11");
+            return;
+        }
         try {
             securityService.registerCryptoKeyProvider(this);
             securityService.registerMqttConnectionProvider(this);