fix: store secrets on disk when partial arn is used #94
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against 42ea983 |
alter-mage
previously approved these changes
Nov 27, 2024
alter-mage
reviewed
Nov 27, 2024
saranyailla
force-pushed
the
fix-partial-arn
branch
from
5d5b169
to
42ea983
Compare
alter-mage
approved these changes
Nov 27, 2024
patrzhan
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
In 2.2.0 and 2.2.1 of secret manager, downloaded secret arns are compared with the exact
arnprovided in the component configuration before writing them to the disk. This breaks the support for partial arn because the downloaded secret arn is complete and doesn't match the partial arn from config.This fix checks if the downloaded secret arn contains the arn from the config instead of checking for exact match.
Why is this change necessary:
Fix the bug introduced in 2.2.0 and 2.2.1 versions of secrets manager.
How was this change tested:
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.