This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
Doc edits #45
Open
billbartlett
wants to merge
47
commits into
aws-quickstart:doc-edits
Choose a base branch
from
splunk:doc-edits
base: doc-edits
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Doc edits #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial commit of user_data.sh -- testing viability of using external shell scripts for user data instead of doing everything in-line with the template.
missed updating the creationpolicy timeout on the previous commit. fixing that, and lowering the timeout to 10 minutes instead of 15.
10 minutes was not enough for the CM to boot before timeout. changed back to 15. changed systemctl commands to use splunk binary moved variables up in user data removed the cloud init files for splunk ansible before ansible is ran
…ked inside the if statement
without something in the functions, bash will error out on a syntax error. added echo statements as placeholders.
Prior to this change, when the script was ran without any arguments, it would still try to execute the base install of Splunk. This change was made so that if someone executes the script to see usage, it won't try to execute the install before showing the usage.
previously, it wrote to /etc/splunk/splunk.license and then the user_data script moved it. that seems unnecessary, so I'm having cloudformation write directly to the appropriate directory.
the minimum number of indexers in an AZ must be at least as large as the replication factor. since we're using RF = 2, and a default minimum of 2 AZ, there must be at least 4 indexers in total - 2 in each AZ.
added sleep in the deployer after restart. this allows for splunk to be fully restarted before issuing splunk cli commands that would fail because the REST endpoint wasn't yet responding.
converted the JSON templates to YAML, which is now required for the quickstart repo.
unfinished docs, but commiting so that they may be shared.
in order to use the automated testing that the AWS Quickstart team provides, the templates need to be named *template.
…kstart ot function
updates to asciidoc documentation.
sshvans
reviewed
May 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@billbartlett Can you pull the latest from the doc-edits origin and merge into your doc-edits branch, and push the changes to this PR?
It seems like your doc-edits branch doesn't have upstream doc-edits changes and therefore I am unable to review the changes by generating the docs locally.
@billbartlett This still needs your attention. 👆🏼 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: This is the initial docs PR for updated Splunk quickstart using the asciidoc format.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.